03-13-2019

For Fixing:
[■]- Mouse pointer left as hand when clicking roll


- Optimization:
SubTheme - particleGroupFront key - appears to be created so that you can put the group on top. 
 [■]* effect can be achieve without the needing key
    [■]- create the group in animatedBG class
    [■]- subtheme SET_DEFAULTS, move the animatedBG.update() on the highest position you want, then on animatedBG SET_DEFAULTS, add the group to theme.params.gameGroup

BackgroundParticle
 [■]- CREATE_TIMER - pra makapagexecute ng code kelangan nya magtawag ng function and then dumaan sa condition ng if(_params.animate), kpg true or false technically 1 line of code lng eexecute nya.
 [■]- START_BG_PARTICLES - nagrarandom number and start lng nung timer
 [■]* ang timer declaration nasa init and function nsa CREATE_TIMER and start nsa START_BG_PARTICLE. masyado kalat kalat ng location. base sa pagkakaintindi ko once lang sineset lahat. Move all codes declation, loop and start to INITIALIZE_PARTICLES. no need to call any functions.
 [■]- onComplete.addOnce(function(){ execute code},_this) - this syntax when called creates a new function, then onComplete executes the function and then disposes the function. when called again creates a new one, execute then dispose. 
 [■]* make it a reusable function. create a function outside then dun mo ilagay ung mga codes. onComplete.addOnce(_this.tweenOnCompleteSample,_this)
    tweenOnCompleteSample:function(){},

InputClass
 [■] - CHECK_DECIMAL / SET_BET - is it needed to call a function and pass parameters just to execute 1 line of InsertComma and Tofixed(4)
 [■] - CHECK_STATE_BUTTON - linked to controls for BTN_2X_VALIDITY and BTN_HALF_VALIDITY. make it link to controls na isang type na lng cya.
 [■] - INPUT_FOCUS_BUTTON_STATE, make same type in subTheme, then dun ilink ung controls and table
 [■]- BET_RESUME, theme pumunta inputClass, pumunta theme.params.betInfo. * execute the betInfo after tawagin ung BET_RESUME sa theme


BetInfo
[■]- AppUtils.insertComma(AppUtils.toNumeric(0).toFixed(4)) - you want to write 0.0000 which is fixed its not a dynamic number. it doesnt need to go through add comma and be converted to number. write "0.0000" directly.
[■]- SLIDER_CHECK_VALIDITY - i dont get this syntax. txtWinChance.alpha = _params.isValid | 0;.. i cant find any reference for _params.isValid
[■]- CHECKING_WINNING - i dont see anyone calling this anymore. remove if not needed
* in general - i think theres too many function calls on bet info. I count 3 times in which bet info will be updated. 
   1 - slider moves
   2 - bet amount adjusted
   3 - display of total wins
  most of the functions can be combined into just 1 call. like roll number, payoutodd win chance, potential payout - they all change when slider is adjusted


Controls
[■]- SHOW_WARNING / HIDE_WARNING - it called the same function twice. call the function once and hold it as a variable. also use else if
if(AppUtils.toNumeric(theme.params.inputClass.update({type:'GET_BET_VALUE'})) != minBet)
if(AppUtils.toNumeric(theme.params.inputClass.update({type:'GET_BET_VALUE'}))
[■]- DISABLE_INPUT - confusing to have a true or false
[■]- SHOW_LOSE_TEXT / SHOW_WIN_TEXT - called from theme SHOW_RESULT.
[■]- SLIDER_CHECK_VALIDITY, already called in theme. then theme has to check for if(_params.isValid) to execute controls.update({type:'HIDE_WARNING'}) / controls.update({type:'SHOW_WARNING'}) - have controls validate what it needs and execute its own functionalities
[■]- SHOW_LOSE_TEXT / SHOW_WIN_TEXT - this is called from Theme SHOW_RESULT. they both trigger the RESET_DICE_ANIMATION.
  * from what i understand this is the entry point for game reset. Have RESET  in theme, and should be called on all classes that needs to be reset


Info
[■] - change onComplete.addOnce implementation

Slider
[■] - combine the textfields update into 1 function type. this is linked to betinfo.
- change the onComplete.addOnce



All Classes:
[■]- avoid doing theme.params.inputClass, theme.params.betInfo, etc. If you need to call a class, hold them as a variable first. dont call theme.params.class everytime its needed.
[■]- minimize up the update calls. combine whatever can be combined.








---------------------
[■] info - change the font color of the sub titles in Button and Display Description... Bet Amount, Potential Payout, Roll Number, Slider Function, Payout Odds, Win Chance, Balance, Roll, Help, Add Funds
[■] info - remove Balance, Profit Points, Add funds - FIXED
[■] Add Funds button needs to be removed. sent message to dan
[■] slider make it hand cursor - FIXED
[■] info - Reports - change the game includes 3 easy to understand...... change it to includes 2 easy to understand..... remove huge wins description... dalawa lang ung tabs na available sa reports - FIXED
[] roll animation - kpg nagaanimate na ung orb tapos maglightning sa baba.. my gap na nakalabas ung lightning pero hnd pa lumalabas ung jar ng number... pagabot nung lightning sa pinakamababa nya paputukin na ung particle ska show ung jar
[] medjo off tlg ung particle ng logo.. pacheck kng hngng saan mapupush n hnd lag
[] GameInfo link to history
[] Make roll animation faster
[■] add total wins label and value
[■] remove play again.
[■] dan modified the UI to accomodate joe's feedback.